Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRO-3122 & PRO-3084: Deprecate did for agentId & use POST /positions #73

Merged
4 commits merged into from
Jun 28, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 27, 2021

Summary of Changes

  • Update all uses of did to instead be agentId
    • Db Migration updates db columns in sms_otp, wallet_credentials, and external_id
    • Update code throughout repo wherever function definitions use did to instead use agentId
    • Update tests
    • Update calls to Bio Auth Service to use agentId instead of id or did
  • Call to Bio Auth Service to get positions now uses POST /positions instead of the deprecated GET
  • Call to Bio Auth Service to verify now sends position and image in a params object instead of deprecated top level field
  • Call to Bio Auth Service to verify no longer sends a backend

Depends on Bio Auth Service PR: kiva/guardian-bio-auth#31

Signed-off-by: Jeff Kennedy <jeffk@kiva.org>
Signed-off-by: Jeff Kennedy <jeffk@kiva.org>
… top-level fields.

Signed-off-by: Jeff Kennedy <jeffk@kiva.org>
Copy link
Contributor

@jsaur jsaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

…3122-did-to-agent-id

Signed-off-by: Jeff Kennedy <jeffk@kiva.org>
@ghost ghost merged commit a3a26aa into master Jun 28, 2021
@ghost ghost deleted the PRO-3122-did-to-agent-id branch June 28, 2021 16:10
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants