Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: my kiva carousel component for borrower status card #5558

Merged
merged 11 commits into from
Oct 3, 2024
Merged

feat: my kiva carousel component for borrower status card #5558

merged 11 commits into from
Oct 3, 2024
+347 −12

Conversation

christian14b
Copy link
Collaborator

Screen.Recording.2024-09-27.at.2.36.15.PM.mov
Screen.Recording.2024-09-27.at.2.37.49.PM.mov

@roger-in-kiva
Copy link
Collaborator

roger-in-kiva commented Oct 1, 2024 •
edited
Loading

Is the See all borrowers cta missing?

Screenshot 2024-10-01 at 2 54 35 p m

@roger-in-kiva
Copy link
Collaborator

Should we add the dividing line at this stage?

Screenshot 2024-10-01 at 2 55 30 p m

@roger-in-kiva
Copy link
Collaborator

Is there a way to test truncated cases?
Screenshot 2024-10-01 at 3 20 56 p m

@christian14b
Copy link
Collaborator Author

Is there a way to test truncated cases? Screenshot 2024-10-01 at 3 20 56 p m

Had to make some adjustments

image

@roger-in-kiva
Copy link
Collaborator

roger-in-kiva commented Oct 3, 2024 •
edited
Loading

Some issues I see:

  • No top rounded corners
Screenshot 2024-10-03 at 12 02 34 p m
  • Negative counter
Screenshot 2024-10-03 at 12 02 41 p m
  • No stylized underline
Screenshot 2024-10-03 at 12 03 50 p m
  • Double asterisk
Screenshot 2024-10-03 at 12 09 27 p m
  • Probably we need some loading placeholder as data is loaded
Screenshot 2024-10-03 at 12 06 08 p m

emuvente
emuvente reviewed Oct 3, 2024
View reviewed changes
src/components/MyKiva/BorrowerCarousel.vue Outdated Show resolved Hide resolved
src/graphql/query/myKiva.graphql Outdated Show resolved Hide resolved
emuvente
emuvente approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@emuvente emuvente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@christian14b christian14b merged commit 2ba435c into main Oct 3, 2024
5 checks passed
@christian14b christian14b deleted the borrower-status-carousel-MP-769 branch October 3, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roger-in-kiva roger-in-kiva roger-in-kiva left review comments

@emuvente emuvente emuvente approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christian14b @roger-in-kiva @emuvente