-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
-help panicking with Go 1.7 #50
Comments
This var here is passed as a nil pointer here. Looking at the stacktrace I think error originates from github.com/fatih/structs and probably it should be reported upstream. |
The var is initialized in the init() function. I'll try to debug the |
I've created a small program using the example code from the README, and it gives the same error when called with |
It's issue with github.com/fatih/structs, the check for IsExported should be adapted as described in golang.org/issue/12367. |
golang/go#12367 says:
|
Flag package tries not to call String() on a zero-value of type registered to a FlagSet: https://github.com/golang/go/blob/7419073/src/flag/flag.go#L390-L394 This PR makes the fieldValue zero-value safe, at least to not panic when calling String(). Fixes koding#50.
After upgrading to Go 1.7 (and 1.7.1),
-help
gives a panic:For reference, my code is available here: https://github.com/deluan/gosonic/blob/master/conf/configuration.go
The text was updated successfully, but these errors were encountered: