Check for correct python2 binary in Makefile #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: issue #13
I decided to go ahead and make that little change, and do it just a wee bit smarter than blindly replacing all instances of
pythonwithpython2, which can't be considered portable. This little shell function should detect which name python2 goes by on a system, and fails if it isn't found. It is notable that this means the whole compilation will fail if python2 isn't found. I doubt this would be a big issue since the build only exists in the first place to run the tests, which require python2. And really, if your version of python is broken you have far more serious concerns for your system than messing around with regular expression libraries!Anyway, maybe also worth noting that truly ancient (read: pre 1990) shells do not understand the "command -v" command. If anyone is using such a shell then this will fail. I recommend that any such person report to the nearest museum for permanent display.
Jokes aside, this tiny little fix should work with any sensible version of make and any halfway sensible shell, and mostly resolves the issue of finding the right python.
EDIT: Eugh. I should really learn to double check things before I make pull requests. I changed a few values to test the changes and forgot to change them back. Everything is ok now. Sorry about that.