-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Gradle/Android Studio #157
Comments
Hi Daniel. You are absolutely right. Including jars was a temporary (read: lazy) solution during the alpha stage (although 2.x series also included jars :P). |
@mvdan do you think that removing gcm completely is a good move? I mean someone could have both F-Droid and Google Play installed (I do :-]), still he/she might want to use a source-certified version (except for the gcm dependency part of course). |
Well, GCM is free software from the client side, so technically speaking we can include it. But it will get the NonFreeDep or NonFreeNet antifeatures, since the app depends in some way on a non-free network/service. I don't know whether GCM has to work for kontalk to work, but that doesn't change much. From our point of view, it would be best if you made a flavour without GCM and we'd build that. The other option is to build with GCM and an antifeature. |
GCM is not strictly needed - manual polling would take its place if Google Play was not found. I guess having an antifeature would make users reluctant to install it. I will make a flavour for the first beta release. What do you think about adding something like a "NonFreeOptionalDep" antifeature? A non-free optional dependency, like in this case. Kontalk needs GCM, but it can work without it. |
This is done. I will track the non-Google flavour creation on issue #181. |
You should get rid of all the jars. We are trying to get all the apps on F-Droid to be built entirely from source, but it's hard to do - if not impossible - if people use jars.
The easiest for you to do would be to use Gradle, and then pull your dependencies from maven central. Please don't use other maven repos - pulling binaries from random places can be hard to check.
One last thing - once you have removed all the jars from the repo, could you use gradle to make a flavour without GCM? We stripped GCM off Telegram for it to be included on F-Droid since it's an indirect non-free dependency, so the same policy applies to Kontalk. The current builds on F-Droid include GCM, but that should change :)
The text was updated successfully, but these errors were encountered: