-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event-based message center communication #1236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Codecov Report
@@ Coverage Diff @@
## master #1236 +/- ##
=========================================
+ Coverage 0.52% 0.53% +0.01%
=========================================
Files 288 330 +42
Lines 25311 24802 -509
Branches 3319 3254 -65
=========================================
Hits 133 133
+ Misses 25165 24656 -509
Partials 13 13
Continue to review full report at Codecov.
|
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Through startForegroundIfNeeded. Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Still doesn't quite work yet... Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
In order to maintain compatibility with current clients, I made a custom stringprep class which skips the toLowerCase call for the localpart. This is needed for Kontalk group JIDs where the group ID (which becomes the localpart) may have capital letters (it's randomly generated). Until a better solution is implemented, but it's quite the work. Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message center will live in the same process forever. Introducing a separate process for it means adding an overhead we don't actually need. Therefore, drop use of intents and broadcasts (even if local) and use a more human approach.
Using https://github.com/greenrobot/EventBus (almost) all commands and events will be converted to events. A few commands impact the internal working of the message center directly, and they will remain as intent-based commands: