Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New service for registration process #1241

Merged
merged 77 commits into from
Mar 31, 2019

Conversation

daniele-athome
Copy link
Member

For deprecating the NumberValidator which is a mess. Will also bring in #1240.

For deprecating the NumberValidator which is a mess.

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
@daniele-athome daniele-athome added the enhancement New feature or request label Nov 22, 2018
@daniele-athome daniele-athome self-assigned this Nov 22, 2018
@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@aee8052). Click here to learn what that means.
The diff coverage is 1.31%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1241   +/-   ##
========================================
  Coverage          ?   1.55%           
========================================
  Files             ?     355           
  Lines             ?   25536           
  Branches          ?    3324           
========================================
  Hits              ?     398           
  Misses            ?   25086           
  Partials          ?      52
Impacted Files Coverage Δ
.../main/java/org/kontalk/provider/UsersProvider.java 0% <ø> (ø)
...main/java/org/kontalk/util/InternalTrustStore.java 0% <ø> (ø)
...java/org/kontalk/service/XMPPConnectionHelper.java 0% <ø> (ø)
...n/java/org/kontalk/crypto/PersonalKeyExporter.java 0% <ø> (ø)
.../main/java/org/kontalk/client/NumberValidator.java 5.25% <ø> (ø)
.../java/org/kontalk/authenticator/Authenticator.java 0% <ø> (ø)
...registration/event/VerificationRequestedEvent.java 0% <0%> (ø)
.../service/registration/event/VerificationError.java 0% <0%> (ø)
...alk/service/registration/event/LoginTestEvent.java 0% <0%> (ø)
...lk/service/registration/event/ThrottlingError.java 0% <0%> (ø)
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aee8052...b46c3c3. Read the comment docs.

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
For now just importing and retrieving keys.

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Albeit it still doesn't work because of the damn progress in the status dialog...

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
1. EventBus-driven IdlingResources
2. Disable progress bars while testing

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Until we find a more stable solution, we'll execute tests
on a local x86 emulator.

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Server will be used by integration tests.

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Though it won't work because it requires adb locally...

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
EventIdlingResources will now be "started" right after performing the ViewAction.

Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
Signed-off-by: Daniele Ricci <daniele@casaricci.it>
@daniele-athome daniele-athome merged commit b46c3c3 into master Mar 31, 2019
@daniele-athome daniele-athome deleted the feature/registration-service branch March 31, 2019 17:47
@daniele-athome daniele-athome added this to the Next milestone Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant