Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voice recording #204

Merged
merged 105 commits into from
Nov 11, 2014
Merged

Voice recording #204

merged 105 commits into from
Nov 11, 2014

Conversation

daniele-athome
Copy link
Member

Following up from issue #58. At a glance:

  • Code style
  • Density-specific icons
  • MessageContentViewFactory: move parameter messageId after parameter component and use varargs for AudioPlayerControl.

acappelli and others added 30 commits December 20, 2013 23:05
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Conflicts:
	src/org/kontalk/message/CompositeMessage.java
	src/org/kontalk/ui/ComposeMessageFragment.java


Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>

Conflicts:
	project.properties
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>

Conflicts:
	app/build.gradle
	app/src/main/AndroidManifest.xml
	app/src/main/java/org/kontalk/ui/ComposeMessageFragment.java
@daniele-athome
Copy link
Member Author

Please remember to create density-specific icons.

// TODO i18n
// FIXME using reflection BAD BAD BAD !!!
for (Class<AttachmentComponent> klass : TRY_COMPONENTS) {
Boolean supported = null;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful using tabs!! Configure your IDE to always use spaces. Please also convert this code to spaces and commit it again.

@daniele-athome daniele-athome modified the milestones: 3.0-beta3, 3.0-beta2 Sep 4, 2014
acappelli and others added 7 commits September 7, 2014 18:13
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>

Conflicts:
	app/build.gradle
Signed-off-by: Andrea Cappelli <a.cappelli87@gmail.com>

Conflicts:
	app/build.gradle
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>

Conflicts:
	app/build.gradle
@daniele-athome daniele-athome self-assigned this Nov 11, 2014
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
Signed-off-by: Daniele Ricci <daniele.athome@gmail.com>
@daniele-athome daniele-athome merged commit 771edd3 into master Nov 11, 2014
@daniele-athome daniele-athome deleted the audio_message branch November 11, 2014 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants