Sync in asyncio #42
Merged
Sync in asyncio #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 96.73% 96.36% -0.38%
==========================================
Files 21 21
Lines 1562 1568 +6
==========================================
Hits 1511 1511
- Misses 51 57 +6
|
|
It looks like the failures I was seeing in #40 were actually being caused by the Python environment caching persisting between different Python versions. Including the Python version in the cache key seems to have resolved things. |
This was referenced Apr 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #40 I had a ton of trouble with
nest-asyncioso I xfailed the sync in asyncio test, merged without it and opened #41 to track this requirement.Starting where I was with
nest-asynciobut may also explore other solutions.Closes #41