Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem when variableMapSize is true and keyMap is used #81

Open
victormsc opened this issue Aug 16, 2023 · 1 comment
Open

Problem when variableMapSize is true and keyMap is used #81

victormsc opened this issue Aug 16, 2023 · 1 comment

Comments

@victormsc
Copy link

When variableMapSize is true and keyMap is used, the function writeObject of the Encoder class throws an exception

Uncaught ReferenceError: encodeKey is not defined

I think that the line

cbor-x/encode.js

Line 614 in d1c5dc8

encode(encodeKey(keys[i]))

should be

encode(encoder.encodeKey(keys[i]))

Is this correct?

Thank you
kriszyp added a commit that referenced this issue Aug 16, 2023
@kriszyp
Fix keyMap usage with variable map size, #81
fa06091
@kriszyp
Copy link
Owner

kriszyp commented Aug 16, 2023 •
edited
Loading

Should be fixed in v1.5.4. Thanks for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kriszyp @victormsc