Update kubernetes_deployment.md #398
Conversation
fixes: kserve#383 Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
✅ Deploy Preview for elastic-nobel-0aef7a ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fixed formatting Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
format Signed-off-by: Rajakavitha Kodhandapani <krajakavitha@gmail.com>
| "disableIngressCreation": true, | ||
| "ingressDomain": "svc.cluster.local", | ||
| "ingressGateway" : "disabled", | ||
| "ingressService" : "disabled" |
There was a problem hiding this comment.
here we also need to set the default ingressClass otherwise you will need to do everything manually later.
If the reason is to decouple from Istio, most of k8s cluster have a default one, we need to give this info to the user e.g. minikube uses nginx.
Instead disabling the ingress would be better to explain both options.
There was a problem hiding this comment.
Please suggest what change needs to be made to the yaml file.
| @@ -1,52 +1,55 @@ | |||
| # Kubernetes Deployment Installation Guide | |||
| KServe supports `RawDeployment` mode to enable `InferenceService` deployment with Kubernetes resources [`Deployment`](https://kubernetes.io/docs/concepts/workloads/controllers/deployment), [`Service`](https://kubernetes.io/docs/concepts/services-networking/service), [`Ingress`](https://kubernetes.io/docs/concepts/services-networking/ingress) and [`Horizontal Pod Autoscaler`](https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale). Comparing to serverless deployment it unlocks Knative limitations such as mounting multiple volumes, on the other hand `Scale down and from Zero` is not supported in `RawDeployment` mode. | |||
|
|
|||
| Kubernetes 1.22 is the minimally required version and please check the following recommended Istio versions for the corresponding | |||
There was a problem hiding this comment.
My understanding was that Istio was not required The current installation guide for raw deployment mode is not accurate. For example, Istio is not needed if disableIngressCreation is enabled. See https://github.com/kserve/kserve/pull/3436
fixes: #383
"Fixes #383 " or "Add description of the problem this PR solves"
Proposed Changes