fix effect chain initialization #1
Conversation
Initialization of the StandardEffectRack depends on PlayerManager creating the channels and registering them with EffectsManager, otherwise EngineEffectChain's m_chainStatusForChannelMatrix is not initialized properly. Previously this was hacked around by EffectChain not creating the EngineEffectChain until it was added to the engine, but we have removed the possibility of an EffectChainSlot existing without having an EngineEffectChain added to the engine.
| @@ -210,6 +211,7 @@ void EffectChainSlot::setDescription(const QString& description) { | |||
|
|
|||
| void EffectChainSlot::setMix(const double& dMix) { | |||
| m_pControlChainMix->set(dMix); | |||
| sendParameterUpdate(); | |||
There was a problem hiding this comment.
Haven't we already connected the sendParamterUpdate() function to the value change of m_pControlChainMix?
There was a problem hiding this comment.
I have tested it by changing the "mix" of some group in the developer tools, and the slot is being triggered on value change.
There was a problem hiding this comment.
Yes, but the valueChanged signal is not emitted when setting the ControlObject from within the class it is a member of. I have stumbled over this a few times working on Mixxx and I am not sure why it works this way, but the workaround is pretty simple.
There was a problem hiding this comment.
When we get rid of the EffectRack layer, I think we should get rid of the mix knob and all other unnecessary ControlObjects for the EQs and QuickEffects. We can just send the engine an update saying the mix parameter is 1 but never allow the user to change it.
solution win xp installation
This brings us back to a functional state where everything is working except for saving/loading XML.