Add optional contentType to formDsl #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @wollnyst, thanks for the PR. |
|
Done. |
e5l
approved these changes
Feb 13, 2019
|
Merged into |
e5l
pushed a commit
that referenced
this pull request
Feb 21, 2019
* Add optional contentType to formDsl * Tests for contentType in formDsl
e5l
pushed a commit
that referenced
this pull request
Feb 25, 2019
* Add optional contentType to formDsl * Tests for contentType in formDsl
e5l
pushed a commit
that referenced
this pull request
Feb 25, 2019
* Add optional contentType to formDsl * Tests for contentType in formDsl
e5l
pushed a commit
that referenced
this pull request
Feb 26, 2019
* Add optional contentType to formDsl * Tests for contentType in formDsl
schleinzer
pushed a commit
to schleinzer/ktor
that referenced
this pull request
Feb 26, 2019
* Add optional contentType to formDsl * Tests for contentType in formDsl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #766
IMO it's enough to add
ContentType, that covers like 99% of upload scenarios now. For all other scenarios we can useappend(key, headers,, bodyBuilder)