-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make worker-threads configurable #175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update also README.md!
And please edit the release note - it's a change that worth having there. |
6ad7efe
to
ae1742a
Compare
I also updated the wording of the release note. ptal |
ae1742a
to
69530e2
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hoyho, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Currently, external-attacher has a hard coded thread count.
However, when user create lot of Pod and PVC currently.
10 thread is not enough to sync VolumeAttachment and PV or it will take
a bit longer time than expected.
Add a configurable flag so that user can configure a suitable value according to their own cluster scale and situation.
Which issue(s) this PR fixes:
Fixes #172
Special notes for your reviewer:
Does this PR introduce a user-facing change?: