-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore wildcard hosts in Istio gateways #1625
Ignore wildcard hosts in Istio gateways #1625
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @haines! |
/check-cla |
/assign @hjacobs |
/assign @Raffo |
This might solve #1518 as well |
I got the same issues like |
ec2fc15
to
d69d191
Compare
I've rebased to bring this branch up to date - @Raffo, are you able to review this please? |
@njuettner seems to be able to approve commits on this project too. @njuettner Please, if you are available, could you review this commit too ? Thank you a lot. |
This is a blocker for us. How can we get this merged? |
cc : @kbhandari |
@@ -300,9 +295,16 @@ func (sc *gatewaySource) hostNamesFromGateway(gateway networkingv1alpha3.Gateway | |||
host = parts[1] | |||
} | |||
|
|||
hostnames = append(hostnames, host) | |||
if host != "*" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you club this check with if host == "" {
in L286?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so - my-namespace/*
is a valid option for the host, so we need to check for *
after stripping the namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes makes sense :)
@haines Thanks for fixing this. LGTM; just a minor comment |
/lgtm |
@njuettner @Raffo This code LGTM. Can we get this merged and have a patch release out for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haines, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1518
Fixes #1624
Istio allows
*
ornamespace/*
asGateway
hosts, meaning that it selects allVirtualService
hosts from the specified namespace (or all namespaces if none is specified).This PR skips such hosts to avoid attempting to create DNS records for
*
(as described in the linked issue this currently causes external-dns to crash).