-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Scaleway DNS as a new provider #1643
Conversation
/assign @njuettner |
/lgtm |
Let's also add an entry in the CHANGELOG. |
@linki done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit, otherwise lgtm
@njuettner Can it be merged? |
/lgtm |
@Sh4d1 do you mind solving the conflicts and then I can merge it |
@njuettner done 😄 |
@njuettner just missed the release 😅 could it be merged before next one? |
/kind feature @Sh4d1 please fix the merge conflicts. Thanks! |
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Signed-off-by: Patrik Cyvoct <patrik@ptrk.io>
Co-authored-by: Nick Jüttner <nick@juni.io>
@seanmalloy ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's go
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, Sh4d1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Patrik Cyvoct patrik@ptrk.io