-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added --txt-prefix to google deployment #1729
Conversation
when using `registry=txt` option, make sure to also use the `txt-prefix` and `txt-owner-id` options as well. If you try to create a `TXT` record in VinylDNS without a prefix, it will try to create a `TXT` record with the same name as your actual DNS record and fail (creating a stranded record `external-dns` cannot manage).
Welcome @prune998! |
/assign @linki |
/lgtm |
/kind documentation |
Don't know how VinylDNS is doing sorting/display of DNS records in management console, but probably the usage of --txt-suffix is better than --txt-prefix. So the TXT records should be sorted alphabetically directly after the corresponding A or CNAME record. |
@prune998 would you be able to confirm that the /lgtm cancel |
This is the doc for Google (Google Cloud DNS), not VinylDNS... @seanmalloy I don't have access to any GKE / Google cloud for now (transitioning job)... Can't test right now. |
/lgtm |
Sorry, you wrote VinylDNS in your first comment and also within your code comments, so I thought it is about that. 😄 |
You're totally right. I removed it and pushed again. The comment is coming from the VinylDNS doc as it works the same way... |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, prune998 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
when using
registry=txt
option, make sure to also use thetxt-prefix
andtxt-owner-id
options as well. If you try to create aTXT
record without a prefix, it will try to create aTXT
record with the same name as your actual DNS record and fail (creating a stranded recordexternal-dns
cannot manage).Checklist