-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Kong's TCPIngress with a load balancer #2109
Conversation
Welcome @krmichel! |
@njuettner or @seanmalloy would either of you have time to take a look at this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. Some small nits, looking forward to merge this 🙂
Co-authored-by: Nick Jüttner <nick@juni.io>
Thanks for taking a look @njuettner. I believe all requested changes have been made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krmichel, njuettner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you @njuettner. I don't know what your release cycle is like. Can you provide an estimate as to when these changes will be available in a released version? |
Description
Add support for Kong's TCPIngress CRD when used with a load balancer service
Checklist