Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source: Dedupe Common Logic #2190

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Source: Dedupe Common Logic #2190

merged 5 commits into from
Aug 11, 2021

Conversation

abursavich
Copy link
Contributor

@abursavich abursavich commented Jul 28, 2021 •
edited
Loading

Description

This deduplicates some common logic in the source package:

  • template parsing
  • template execution
  • event handlers
  • cache syncing

It also renames files to be prefixed with their api name, which make them more consistent with their config/flag names (e.g. skipper-routegroup: routegroup.go -> skipper_routegroup.go) and helps clarify/resolve conflicts (e.g. renaming gateway.go to istio_gateway.go makes way for the gateway api).

Prelude to #2045

Checklist

  • Unit tests updated (N/A: no behavior change)
  • End user documentation updated (N/A)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 28, 2021
@abursavich
Copy link
Contributor Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 28, 2021
@seanmalloy
Copy link
Member

/cc

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 28, 2021
njuettner
njuettner approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abursavich, njuettner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 11, 2021
@njuettner
Copy link
Member

@k8s-ci-robot k8s-ci-robot merged commit a690bb9 into kubernetes-sigs:master Aug 11, 2021
@abursavich abursavich deleted the source-cleanup branch August 11, 2021 14:12
@abursavich abursavich mentioned this pull request Sep 14, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njuettner njuettner njuettner approved these changes

@Raffo Raffo Awaiting requested review from Raffo

@seanmalloy seanmalloy Awaiting requested review from seanmalloy

Assignees

@njuettner njuettner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abursavich @seanmalloy @k8s-ci-robot @njuettner