-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions of dependencies #2218
Conversation
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: GitHub <noreply@github.com>
I don't have a problem with this PR, but I wanted to offer some context on an alternative. I worked on roughly the same problem a few weeks ago (#2045 (comment)), but after fixing breakages to the fake dynamic clients in tests I was still worried that there may be similar breakages to the real dynamic clients. I ended up replacing all of the dynamic clients with generated static clients and have been submitting small PRs building up to it. You can check out all of my remaining changes, including adding the Gateway API sources, but looking at the whole thing in one shot might be a little overwhelming. It's logically broken up into smaller chunks for PRs that do one thing at a time (e.g. gloo, contour, ambassador, etcd, kong, gateway, skipper). From my side I just needed upgraded k8s dependencies, so I'm happy to have that either way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njuettner, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR bumps most dependencies to recent versions. It is needed to pave the path to kubernetes 1.22 and reduce 10 vulnerabilities that can be found today in the ExternalDNS binary.
This included:
Before I squash the commits, I would love to understand if this makes sense to other people, especially @njuettner .