Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump versions of dependencies #2218

Merged
merged 14 commits into from
Aug 27, 2021
Merged

Bump versions of dependencies #2218

merged 14 commits into from
Aug 27, 2021

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Aug 12, 2021

This PR bumps most dependencies to recent versions. It is needed to pave the path to kubernetes 1.22 and reduce 10 vulnerabilities that can be found today in the ExternalDNS binary.

This included:

  • remove the dependency on kubernetes the main repo: we should never depend on that one.
  • remove unsupported countour APIs.
  • bump to a much newer etcd library.
  • adjust for azure deprecated methods.
  • fixed CodeQL to account for a strict go 1.16 requirement.

Before I squash the commits, I would love to understand if this makes sense to other people, especially @njuettner .

Raffo and others added 10 commits August 10, 2021 13:48
Signed-off-by: GitHub <noreply@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 12, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2021
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 12, 2021
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 12, 2021
Raffo and others added 2 commits August 12, 2021 17:30
Signed-off-by: Raffaele Di Fazio <raffo@github.com>
Signed-off-by: GitHub <noreply@github.com>
@abursavich
Copy link
Contributor

I don't have a problem with this PR, but I wanted to offer some context on an alternative. I worked on roughly the same problem a few weeks ago (#2045 (comment)), but after fixing breakages to the fake dynamic clients in tests I was still worried that there may be similar breakages to the real dynamic clients. I ended up replacing all of the dynamic clients with generated static clients and have been submitting small PRs building up to it.

You can check out all of my remaining changes, including adding the Gateway API sources, but looking at the whole thing in one shot might be a little overwhelming. It's logically broken up into smaller chunks for PRs that do one thing at a time (e.g. gloo, contour, ambassador, etcd, kong, gateway, skipper).

From my side I just needed upgraded k8s dependencies, so I'm happy to have that either way.

Copy link
Member

@njuettner njuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit b03da00 into master Aug 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: njuettner, Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants