Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated rnds provider #4788

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Remove deprecated rnds provider #4788

merged 1 commit into from
Oct 4, 2024

Conversation

Raffo
Copy link
Contributor

@Raffo Raffo commented Oct 3, 2024

Description

This PR removes the deprecated RDNS provider as mentioned in #4347 (comment).

Signed-off-by: Raffaele Di Fazio <difazio.raffaele@gmail.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 3, 2024
@Raffo
Copy link
Contributor Author

Raffo commented Oct 3, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Raffo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2024
@mloiseleur
Copy link
Contributor

I haven't seen anything missed.
There is no go.mod to remove this time, since go.etcd.io/etcd/client/v3 is also used by coredns provider.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit cda94eb into master Oct 4, 2024
14 checks passed
@Raffo Raffo deleted the raffo/remove-rdns branch October 4, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants