Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cilium operator metrics activation #8000

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Fix Cilium operator metrics activation #8000

merged 1 commit into from
Sep 22, 2021

Conversation

L3o-pold
Copy link
Contributor

@L3o-pold L3o-pold commented Sep 22, 2021

What type of PR is this?
/kind bug

What this PR does / why we need it:

This PR aims to solve bad metrics activation for Cilium operator.

Scraping annotations are enabled here https://github.com/Infomaniak/kubespray/blob/master/roles/network_plugin/cilium/templates/cilium-deploy.yml.j2#L23

Port is declared here:
https://github.com/Infomaniak/kubespray/blob/master/roles/network_plugin/cilium/templates/cilium-deploy.yml.j2#L117

But metrics are not enabled. In the official helm chart they enable it in the configmap here: https://github.com/cilium/cilium/blob/1.8.12/install/kubernetes/cilium/charts/config/templates/configmap.yaml#L137

It result in an Connection refused error when trying to query the :6942/metrics endpoint.

Which issue(s) this PR fixes:

Fixes none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Cilium] Fix operator metrics activation (`enable-metrics` key missing)

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 22, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @L3o-pold. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 22, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 22, 2021
@L3o-pold L3o-pold changed the title Fix cilium operator metrics activation Fix Cilium operator metrics activation Sep 22, 2021
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, L3o-pold

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2021
@oomichi
Copy link
Contributor

oomichi commented Sep 22, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 598f178 into kubernetes-sigs:master Sep 22, 2021
@floryut floryut added kind/network Network section in the release note and removed kind/bug Categorizes issue or PR as related to a bug. labels Sep 23, 2021
rtsp pushed a commit to rtsp/kubespray that referenced this pull request Sep 23, 2021
oomichi pushed a commit to oomichi/kubespray that referenced this pull request Sep 28, 2021
k8s-ci-robot pushed a commit that referenced this pull request Sep 29, 2021
This is a cherry-pick of 598f178

Co-authored-by: Léopold Jacquot <leopold.jacquot@infomaniak.com>
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Oct 23, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants