-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Cilium operator metrics activation #8000
Fix Cilium operator metrics activation #8000
Conversation
Hi @L3o-pold. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: floryut, L3o-pold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
This is a cherry-pick of 598f178
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR aims to solve bad metrics activation for Cilium operator.
Scraping annotations are enabled here https://github.com/Infomaniak/kubespray/blob/master/roles/network_plugin/cilium/templates/cilium-deploy.yml.j2#L23
Port is declared here:
https://github.com/Infomaniak/kubespray/blob/master/roles/network_plugin/cilium/templates/cilium-deploy.yml.j2#L117
But metrics are not enabled. In the official helm chart they enable it in the configmap here: https://github.com/cilium/cilium/blob/1.8.12/install/kubernetes/cilium/charts/config/templates/configmap.yaml#L137
It result in an
Connection refused
error when trying to query the:6942/metrics
endpoint.Which issue(s) this PR fixes:
Fixes none
Special notes for your reviewer:
Does this PR introduce a user-facing change?: