Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise multiple ansible versions in CI #8172

Merged
merged 6 commits into from
Nov 11, 2021

Conversation

cristicalin
Copy link
Contributor

@cristicalin cristicalin commented Nov 9, 2021

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR splits the ansible requirements.txt files on a per-version basis and ensures to test each major supported version in CI for at least one mandatory job.

Which issue(s) this PR fixes:

Fixes #8166

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Multiple Ansible versions are now supported (2.9/2.10/2.11) and tested by CI

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 9, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 9, 2021
@cristicalin cristicalin force-pushed the multiple_ansible branch 4 times, most recently from b883f30 to 877a3a8 Compare November 9, 2021 17:36
@cristicalin cristicalin changed the title Exericse multiple ansible versions in CI Exericise multiple ansible versions in CI Nov 9, 2021
@cristicalin cristicalin changed the title Exericise multiple ansible versions in CI Exercise multiple ansible versions in CI Nov 9, 2021
@cristicalin
Copy link
Contributor Author

It looks like #8160 did not address the path_join issue after all.

…y to mitigate missing behavior in older ansible versions
Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cristicalin Awesome; that will definitely help 🍾

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@oomichi
Copy link
Contributor

oomichi commented Nov 11, 2021

Thanks for improving test patterns for ansible versions.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 0d0468e into kubernetes-sigs:master Nov 11, 2021
@floryut floryut mentioned this pull request Dec 21, 2021
unai-ttxu pushed a commit to Stratio/kubespray that referenced this pull request Mar 3, 2022
* Ansible: separate requirements files for supported ansible versions

* Ansible: allow using ansible 2.11

* CI: Exercise Ansible 2.9 and Ansible 2.11 in a basic AIO CI job

* CI: Allow running a reset test outside of idempotency tests and running it in stage1

* CI: move ubuntu18-calico-aio job to stage2 and relay only on ubuntu20 with the variously supported ansible versions for stage1

* CI: add capability to install collections or roles from ansible-galaxy to mitigate missing behavior in older ansible versions
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
* Ansible: separate requirements files for supported ansible versions

* Ansible: allow using ansible 2.11

* CI: Exercise Ansible 2.9 and Ansible 2.11 in a basic AIO CI job

* CI: Allow running a reset test outside of idempotency tests and running it in stage1

* CI: move ubuntu18-calico-aio job to stage2 and relay only on ubuntu20 with the variously supported ansible versions for stage1

* CI: add capability to install collections or roles from ansible-galaxy to mitigate missing behavior in older ansible versions
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
* Ansible: separate requirements files for supported ansible versions

* Ansible: allow using ansible 2.11

* CI: Exercise Ansible 2.9 and Ansible 2.11 in a basic AIO CI job

* CI: Allow running a reset test outside of idempotency tests and running it in stage1

* CI: move ubuntu18-calico-aio job to stage2 and relay only on ubuntu20 with the variously supported ansible versions for stage1

* CI: add capability to install collections or roles from ansible-galaxy to mitigate missing behavior in older ansible versions
itayporezky added a commit to itayporezky/kubespray that referenced this pull request May 15, 2024
itayporezky added a commit to itayporezky/kubespray that referenced this pull request May 16, 2024
itayporezky added a commit to itayporezky/kubespray that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exercise multiple ansible versions in CI
4 participants