-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cinder CSI to v1.22 #8296
Update Cinder CSI to v1.22 #8296
Conversation
Hi @StevenReitsma. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
Thanks. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oomichi, StevenReitsma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Cinder CSI is broken from Kubernetes 1.22 onwards because of the removal of deprecated
storage.k8s.io/v1beta
resources.https://kubernetes.io/docs/reference/using-api/deprecation-guide/#storage-resources-v122
This PR updates the manifests to the templated versions of the latest official manifests in https://github.com/kubernetes/cloud-provider-openstack/tree/master/manifests/cinder-csi-plugin
Which issue(s) this PR fixes:
Special notes for your reviewer:
Tested on an Openstack cluster, works successfully.
Bumping the versions of the csi_attacher, provisioner etc containers also impact the AWS EBS plugin, but I'm unable to test it. Doesn't look like it's actively maintained anyway so 🤷
Does this PR introduce a user-facing change?:
Should work from Kubernetes 1.19+. Will break on anything lower than v1.19