Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Calico BGPPeer sourceAddress #8306

Merged

Conversation

kakkotetsu
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add support for Calico sourceAddress parameter BGPPeer resource.
This parameter is so useful on "per peer" model.
This parameter was added in Calico v3.18.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[Calico] Add support for BGPPeer sourceAddress

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 15, 2021

CLA Signed

The committers are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @kakkotetsu!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 15, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @kakkotetsu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 15, 2021
@kakkotetsu
Copy link
Contributor Author

I signed the CLA

@cristicalin
Copy link
Contributor

Great feature @kakkotetsu !

/check-cla
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2021
@cristicalin
Copy link
Contributor

@kakkotetsu please ensure to also sign the CNCF agreement: https://git.k8s.io/community/CLA.md#the-contributor-license-agreement

@kakkotetsu
Copy link
Contributor Author

oh, I signed CNCF agreement.

Copy link
Member

@floryut floryut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kakkotetsu Thanks for the PR 👍

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2021
@floryut floryut added kind/network Network section in the release note approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 15, 2021
@jayonlau
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2021
@cristicalin
Copy link
Contributor

/check-cla

@cristicalin
Copy link
Contributor

@kakkotetsu could you try closing and reopening the PR to address the CLA check?

@kakkotetsu kakkotetsu closed this Dec 16, 2021
@kakkotetsu kakkotetsu reopened this Dec 16, 2021
@kakkotetsu kakkotetsu closed this Dec 16, 2021
@kakkotetsu kakkotetsu reopened this Dec 16, 2021
@kakkotetsu
Copy link
Contributor Author

@cristicalin
I did it.

@cristicalin
Copy link
Contributor

@kakkotetsu please check again that you have correctly signed the linuxfoundation CLA (https://identity.linuxfoundation.org/projects/cncf)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 20, 2021
@kakkotetsu
Copy link
Contributor Author

@cristicalin
I'm sorry it took so long.

I signed only Individual Contributor License Agreement (“Agreement”) v2.0 , and now I signed CNCF INDIVIDUAL CONTRIBUTOR LICENSE AGREEMENT VERSION 1.0("AGREEMENT") too, so it passed.
Through trial and error, I ran git commit --amend --reset-author and git push -f, which removed the lgtm tag.

@cristicalin
Copy link
Contributor

Thanks @kakkotetsu !

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cristicalin, floryut, kakkotetsu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c59407f into kubernetes-sigs:master Dec 20, 2021
@kakkotetsu kakkotetsu deleted the calico-sourceaddress branch December 20, 2021 09:55
@floryut floryut mentioned this pull request Dec 21, 2021
sakuraiyuta pushed a commit to sakuraiyuta/kubespray that referenced this pull request Apr 16, 2022
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/network Network section in the release note lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants