-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] add a node selector support for loadbalancer services #2601
[occm] add a node selector support for loadbalancer services #2601
Conversation
87ca5fe
to
5f58546
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise looks good, but perhaps worth of adding test for util.go stuff
also @ririko-nakamura is missing cla
fc1657b
to
dc5dfd4
Compare
dc5dfd4
to
13a09b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
} | ||
|
||
for k, v := range filterLabels { | ||
if nodeLabelValue, ok := node.Labels[k]; !ok || (v != "" && nodeLabelValue != v) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure add a info.v(6) for the not match will be helpful for debug?
/lgtm |
generally only with bugs to backport.. |
Yeah, I'm not opposed to backporting this, seems like it was highly anticipated. @stephenfin, @mdbooth, how do you look at this? |
/cherry-pick release-1.30 |
/cherry-pick release-1.29 |
/cherry-pick release-1.28 |
@kayrus: new pull request created: #2603 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kayrus: new pull request created: #2604 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@kayrus: #2601 failed to apply on top of branch "release-1.28":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…tes#2601) * POC of TargetNodeLabels selector on OpenStack LB * Fix type errors * Update implementation of getKeyValuePropertiesFromServiceAnnotation * gofmt -w -s ./pkg * Polish the code and add documentation --------- Co-authored-by: Ririko Nakamura <ririko.nakamura@outlook.com>
…2605) * POC of TargetNodeLabels selector on OpenStack LB * Fix type errors * Update implementation of getKeyValuePropertiesFromServiceAnnotation * gofmt -w -s ./pkg * Polish the code and add documentation --------- Co-authored-by: Ririko Nakamura <ririko.nakamura@outlook.com>
What this PR does / why we need it:
This PR adds an ability to specify loadbalancer service with a node selector.
Big thanks to @ririko-nakamura for the initial code.
A new OCCM
node-selector
option is added into the[LoadBalancer]
config section.And a new
loadbalancer.openstack.org/node-selector
service annotation support is added.Which issue this PR fixes(if applicable):
fixes #1770
Special notes for reviewers:
Release note: