Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable go mod once in travis #3935

Closed
wants to merge 1 commit into from

Conversation

shu-mutou
Copy link
Contributor

@shu-mutou shu-mutou commented Jun 17, 2019

We need to investigate to use go mod in travis.
For now, change GO111MODULE to off in travis.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shu-mutou
To complete the pull request process, please assign cupofcat
You can assign the PR to them by writing /assign @cupofcat in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 17, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 17, 2019
@shu-mutou
Copy link
Contributor Author

npm ci seems to update go.mod file to use latest. Also, prometheus/client-golang was bumped latest to 1.0.0 few days ago, then prometheus.Handler() removed.

@maciaszczykm
Copy link
Member

Hmm, @eloyekunle can you help us there?

We need to investigate to use `go mod` in travis.
For now, change `GO111MODULE` to off in travis.
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 17, 2019
@shu-mutou shu-mutou changed the title [WIP] Fix test:backend:coverage task in favor of using go mod Disable go mod once in travis Jun 17, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 17, 2019
@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #3935 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3935   +/-   ##
=======================================
  Coverage   46.63%   46.63%           
=======================================
  Files         176      176           
  Lines        8133     8133           
  Branches       71       71           
=======================================
  Hits         3793     3793           
  Misses       4106     4106           
  Partials      234      234

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 708e606...e44a804. Read the comment docs.

@shu-mutou
Copy link
Contributor Author

I updated this PR as disabling go mod in travis.
Also, I posted Issue #3936. @eloyekunle Could you investigate this issue?

@maciaszczykm
Copy link
Member

cc @floreks AFAIK you enabled Go modules. We need them, arent we?

@shu-mutou
Copy link
Contributor Author

Basically, I agree with using go mod, but we need to investigate it more. 😉

@eloyekunle
Copy link
Contributor

I will look into it.

@eloyekunle
Copy link
Contributor

go get for golangci-lint in the postinstall script was updating some packages. In #3934, we download golangci-lint via curl instead.

@shu-mutou
Copy link
Contributor Author

shu-mutou commented Jun 18, 2019

@eloyekunle Thank you for your help! I understood we should not use go get to install tools.

@shu-mutou shu-mutou deleted the fix-backend-coverage branch June 18, 2019 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants