Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cognito permissions for AWS LBC #15910

Merged

Conversation

danports
Copy link
Contributor

This is needed for configuring Cognito authentication. The cognito-idp:DescribeUserPoolClient permission has been present in the upstream install docs for a long time. I haven't looked into the integration test infrastructure so I have no idea if I should have updated all of the stuff in tests/integration/update_cluster.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @danports. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 14, 2023
@hakman
Copy link
Member

hakman commented Sep 14, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 14, 2023
@hakman
Copy link
Member

hakman commented Sep 14, 2023

I haven't looked into the integration test infrastructure so I have no idea if I should have updated all of the stuff in tests/integration/update_cluster.

Try running hack/update_expected.sh.

@hakman
Copy link
Member

hakman commented Sep 14, 2023

Please squash commits when all tests are passing :)

@danports
Copy link
Contributor Author

I ran hack/update_expected.sh but it didn't change anything, so I'm guessing the earlier test failures (besides the gofmt issue I just fixed) are flakes?

@hakman
Copy link
Member

hakman commented Sep 14, 2023

Failed tests are just flakes. Once you squash, I will approve the PR. 👍

@danports
Copy link
Contributor Author

Alright, squashed!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit c42169a into kubernetes:master Sep 14, 2023
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 14, 2023
@danports
Copy link
Contributor Author

Can we backport this to 1.27? Do these commands work?

/cherrypick release-1.27
/cherrypick release-1.28

@danports danports deleted the aws-lbc-cognito-permissions branch September 14, 2023 18:57
k8s-ci-robot added a commit that referenced this pull request Sep 15, 2023
…10-upstream-release-1.27

Automated cherry pick of #15910: Add Cognito permissions for AWS LBC.
k8s-ci-robot added a commit that referenced this pull request Sep 15, 2023
…10-upstream-release-1.28

Automated cherry pick of #15910: Add Cognito permissions for AWS LBC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants