Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip_regex.go: kube-router add back in service afinity test #16188

Merged
merged 1 commit into from
Dec 23, 2023
Merged

skip_regex.go: kube-router add back in service afinity test #16188

merged 1 commit into from
Dec 23, 2023

Conversation

aauren
Copy link
Contributor

@aauren aauren commented Dec 21, 2023 •
edited
Loading

@hakman

Requires kubernetes/kubernetes#122440 to be merged first.

Once those two are merged, kube-router should be passing both of the service affinity tests in the e2e suite, so we can allow those to run and no longer worry about failures.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @aauren. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hakman hakman changed the title Draft: skip_regex.go: kube-router add back in service afinity test WIP skip_regex.go: kube-router add back in service afinity test Dec 22, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 22, 2023
@aauren
Copy link
Contributor Author

aauren commented Dec 22, 2023

Closing this given the feedback on kubernetes/kubernetes#122440

@aauren aauren closed this Dec 22, 2023
@aauren
Copy link
Contributor Author

aauren commented Dec 23, 2023

Accidentally closed this one too quickly. This one can be merged now that kubernetes/kubernetes#122440 has been merged.

@aauren aauren reopened this Dec 23, 2023
@aauren aauren changed the title WIP skip_regex.go: kube-router add back in service afinity test skip_regex.go: kube-router add back in service afinity test Dec 23, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 23, 2023
@hakman
Copy link
Member

hakman commented Dec 23, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 23, 2023
@hakman
Copy link
Member

hakman commented Dec 23, 2023

/test ?

@hakman
Copy link
Member

hakman commented Dec 23, 2023

/test pull-kops-e2e-cni-kuberouter

@kubernetes kubernetes deleted a comment from k8s-ci-robot Dec 23, 2023
@rifelpet
Copy link
Member

We should update this logic to only skip for k8s versions < 1.30. We wont see the impact of this skip removal until 1.30 is stable though because both the periodic and presubmit tests for kuberouter use the latest stable builds of k/k, not the CI builds.

We could also switch them to use CI until then.

@hakman
Copy link
Member

hakman commented Dec 23, 2023

@rifelpet kubernetes/test-infra#31511

@hakman
Copy link
Member

hakman commented Dec 23, 2023

/test pull-kops-e2e-cni-kuberouter

@hakman
Copy link
Member

hakman commented Dec 23, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit c4e229e into kubernetes:master Dec 23, 2023
23 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Dec 23, 2023
@aauren aauren mentioned this pull request Apr 21, 2024
Closed
11 tasks
@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemarkus olemarkus Awaiting requested review from olemarkus

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@aauren @k8s-ci-robot @hakman @rifelpet