Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Cilium 1.14.5 #16214

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Update to Cilium 1.14.5 #16214

merged 2 commits into from
Jan 4, 2024

Conversation

hakman
Copy link
Member

@hakman hakman commented Jan 4, 2024 •
edited
Loading

This fixes Cilium ENI mode tests

/cc @rifelpet

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 4, 2024
@hakman
Copy link
Member Author

hakman commented Jan 4, 2024

@zadjadr FYI, bumping to Cilium 1.14.5 fixes the ENI mode.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 4, 2024
@rifelpet
Copy link
Member

rifelpet commented Jan 4, 2024

I see the eni fix was backported to 1.13 and 1.12 cilium/cilium#29335 we should bump the cilium versions in the kops release branches too

@hakman
Copy link
Member Author

hakman commented Jan 4, 2024

/test pull-kops-e2e-cni-cilium

@zadjadr
Copy link
Contributor

zadjadr commented Jan 4, 2024

Thanks for the info and update. Seems like cilium just wasn’t quite ready yet.

@hakman
Copy link
Member Author

hakman commented Jan 4, 2024

Thanks for the info and update. Seems like cilium just wasn’t quite ready yet.

Wondering how they actually test releases...

@k8s-ci-robot k8s-ci-robot merged commit a8305d2 into kubernetes:master Jan 4, 2024
26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Jan 4, 2024
@rifelpet rifelpet mentioned this pull request Jan 4, 2024
Merged
@rifelpet
Copy link
Member

rifelpet commented Jan 4, 2024

Spot checking the grid jobs that have already ran since this was merged, it doesn't seem to have helped:

https://testgrid.k8s.io/kops-grid#kops-grid-cilium-eni-amzn2-k26

@hakman
Copy link
Member Author

hakman commented Jan 4, 2024

@rifelpet See https://testgrid.k8s.io/kops-network-plugins#kops-aws-cni-cilium-eni

@BrewTestBot BrewTestBot mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rifelpet rifelpet rifelpet approved these changes

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
4 participants
@hakman @k8s-ci-robot @rifelpet @zadjadr