-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws: Use domain
instead of vpc
when rendering aws_eip
#16237
Conversation
/cc @rifelpet |
That PR was merged in the terraform-provider-aws version v5.0.0. I think we'll want to bump our minimum version too https://github.com/hakman/kops/blob/70bba2edfc45002e5c3d78f284f77f34b8f9ac53/upup/pkg/fi/cloudup/terraform/target_hcl2.go#L244 |
d609091
to
67b9148
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Ref: hashicorp/terraform-provider-aws#26714