aws: fix maxPods when cilium ipam=eni is used

[argusua]

What does this PR introduce?
This PR addresses the issue where kubelet is configured with maxPods 100 in the AWS environment and when cilium with ipam=eni is used.

Why is this change needed?
The number of IP addresses is connected to the AWS instance type and is much less than 100 which is the default maxPods value. So, for small instance types we in most cases end up with the pod not being able to schedule because of 'No IP's left to assign on aws instances'

How does it address the issue?
We use the same code to determine maxPods per AWS instance type as for amazonvpc networking.

Related Issue
Fixes #16064

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: argusua / name: Dmytro Kozlovskyi (d9075f1)

[k8s-ci-robot]

Welcome @argusua!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @argusua. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

Hi @argusua. Thanks for taking the time to submit a PR.
Please sign the CLA to be able to accept it.

[argusua]

Hi @argusua. Thanks for taking the time to submit a PR. Please sign the CLA to be able to accept it.

Done.

[hakman]

/ok-to-test

[argusua]

Can someone help with failed tests? Because for me it's not clear why they are failing. I've tried building and running nodeup on my test cluster with amazonvpc and cilium cni and it works correctly.

[argusua]

Thanks, @hakman It was also my thought but not clear why I can't recreate this on my local cluster. Anyway, I've commited your suggestion. Let's if this helps.

[argusua]

/retest-required

[argusua]

/test pull-kops-e2e-k8s-aws-calico

[argusua]

Hi, @hakman
Was able to recreate the issue locally too, and your suggestion has fixed it. Also, looks like the tests here are green now. Thanks.

[hakman]

Thanks @argusua. If you don't mind, could you also squash the commits?

[argusua]

Hi, @hakman
Done

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment