-
Notifications
You must be signed in to change notification settings - Fork 39.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: New kubectl command kubectl debug
#45922
Comments
How are we going to hide this? I can think of a couple ways:
FYI, code freeze for 1.7 is a week from tomorrow, so this will need to be fully reviewed, approved and have all checks passing by then to make it into 1.7. You probably want to send an MVP for review ASAP, so follow up later with anything that is non-trivial to implement and not part of the MVP. |
ack, thanks. Will dig into which is easier and create an MVP ASAP. |
Thinking about this a little bit more, it would be nice to integrate the same feature gates used with the rest of kubernetes into kubectl. I was going to add a flag to set feature gates, but this has a couple of downsides:
I settled on an environment variable as a decent way to do this and opened #46151. Using this, |
Automatic merge from submit-queue Add alpha command to kubectl Also allow new commands to disable themselves by returning a nil value. This can be used to disable commands based on feature gates. **What this PR does / why we need it**: Method of enabling alpha functionality in kubectl **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: ref kubernetes#45922 **Special notes for your reviewer**: Part of a discussion in kubernetes#45922 with @pwittrock **Release note**: ```release-note NONE ```
@verb: GitHub didn't allow me to assign the following users: aaron-prindle. Note that only kubernetes members can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@aaron-prindle is interested in working on this. /assign @verb |
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
/remove-lifecycle stale |
Hey I just ran into this, I'm running
And then |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Seems like this would be a good fit for a |
@t3hmrman oh that's neat, I didn't know about the plugins, I don't think they were around when I first added /remove-lifecycle stale |
@verb I'm also think they weren't -- I'm not sure when kubectl plugins became a thing, but I'm really hoping other operators will use them instead of building their own CLI tools. Not sure if it completely satisfies the needs of this ticket, but thought it was worth a mention! Currently I avoid operators that introduce their own CLI tools to manage resources (so for a concrete example, zalando/patroni over CrunchyData/postgres-operator) |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reopening now that #59416 has merged. /reopen |
@verb: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/remove-lifecycle rotten |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
/remove-lifecycle stale |
/kind feature |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Working on this for 1.18. /remove-lifecycle stale |
Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST
SIG Node is working on new functionality (feature: kubernetes/enhancements#277 , proposal: #35584) to execute a "Debug Container" in the context of a running pod for the purposes of troubleshooting. This issue is to discuss changes needed to kubectl to surface this feature.
We're aiming for an alpha release in 1.7 that includes basic functionality. As written, the proposal in #35584 calls for a new command,
kubectl debug
, that resembleskubectl exec
. An example run is:Ideally we could have reasonable defaults so that the minimum command would be something like:
One departure from
kubectl exec
is thatkubectl debug
supports reattaching to a running Debug Container with a command likekubectl debug --reattach $POD $CONTAINER_NAME
Options for the command would resemble:
Since this is an alpha feature it might be nice to be able to hide it in kubectl unless alpha features are enabled. It will return an error on clusters with alpha features disabled (the default).
/cc @pwittrock
The text was updated successfully, but these errors were encountered: