remove --tls-ca-file which had no effect #58968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, dims The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 58955, 58968, 58971, 58963, 58298). If you want to cherry-pick this change to another branch, please follow the instructions here. |
githubixx
pushed a commit
to githubixx/ansible-role-kubernetes-controller
that referenced
this pull request
Jun 3, 2018
SemanticallyNull
added a commit
to cloudfoundry-incubator/kubo-release
that referenced
this pull request
Jun 11, 2018
- kubernetes/kubernetes#58968 [#158183539] Signed-off-by: Urvashi Reddy <ureddy@pivotal.io>
githubixx
added a commit
to githubixx/ansible-role-kubernetes-controller
that referenced
this pull request
Jun 13, 2018
* removed tls-cert-file setting as it is deprecated (see kubernetes/kubernetes#58968) * remove deprecated kube-apiserver parameter insecure-bind-address / added variable+parameter secure-port for kube-apiserver * added kube-controller-manager certificate files to k8s_certificates list * update README * added kube-scheduler certificate files to k8s_certificates list * updated README * added kube-controller-manager-sa certificate files to k8s_certificates list * removed unneeded files from k8s_certificates list * change K8s release to v1.10.3 * added kubeconfig for admin user, controller manager, scheduler / introduce k8s_scheduler_conf_dir, k8s_controller_manager_conf_dir / k8s_release to v1.10.3 / update README * replaced kube-apiserver parameter admission-control with enable-admission-plugins * new service-account-key-file value for kube-apiserver * changes in k8s_controller_manager_settings: removed master parameter, added kubeconfig, new value for service-account-private-key-file, new parameter use-service-account-credentials * update to K8s v1.10.4 * update README * implemented needed changes for kube-scheduler * kubectl now uses --kubeconfig * fix wrong directory destinations * added k8s-controller-base tag / fixed wrong tags
MaximilianMeister
added a commit
to MaximilianMeister/salt
that referenced
this pull request
Aug 2, 2018
see kubernetes/kubernetes#58968 k8s#1.11 Signed-off-by: Maximilian Meister <mmeister@suse.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flag has had no effect since we started configuring loopback based on the direct cert. I've marked it deprecated this release so we don't break launch scripts right away, but its coming. I think we should remove it in 1.11.