-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
external-dns: Drop linting job for PR #31422
external-dns: Drop linting job for PR #31422
Conversation
@mrueg I am not sure if it makes more sense to save prow compute or actions compute given that actions has minutes that aren't unlimited and we don't have a specisl agreement with them like we do for prow (given that we are an official project). And yes the license check is something we absolutely need. |
Ok, after thinking more about this, I've seen this job blocking PRs from being merged many times and that is simply damaging the project. I would say that we can disable this and have the license check done in another place. @mrueg if you are willing to add a PR to external DNS for the license check, then I'm happy to approve this one. |
It works for me too |
@mrueg can you rebase this one? |
d4f365b
to
05d1258
Compare
Github actions already lints so we can skip this here and safe some compute on prow. Signed-off-by: Manuel Rüger <manuel@rueg.eu>
05d1258
to
48f728f
Compare
I've rebased and reduced it to the licensecheck target. |
/lgtm |
I'm not sure if I can, but I'll try: |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur, mrueg, Raffo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mrueg: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Github actions already lints so we can skip this here and safe some compute on prow.
If the licensecheck is something you'd want to preserve, we should add this to github actions as well.
Context: kubernetes-sigs/external-dns#4078 (comment)
@johngmyers @Raffo @njuettner @szuecs @mloiseleur