-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API reference v1.23 #29668
API reference v1.23 #29668
Conversation
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: 294c5dc 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/613c7cfbb4d2c40008f2851d 😎 Browse the preview: https://deploy-preview-29668--kubernetes-io-main-staging.netlify.app |
/milestone 1.23 |
@feloy thanks for getting a jump start on this! Is the plan to test it now and re-run it once SIG Release starts cutting release candidates (rc)? |
@jimangel my idea is to update this PR as soon as new alpha/beta/RC are released, as is it easier to incorporate API changes by small chunks. |
/cc @jlbutler @mehabhalodiya @chrisnegus @ramrodo @nate-double-u (1.23 Docs Release Team) |
/assign |
👷 Deploy Preview for kubernetes-io-vnext-staging processing. 🔨 Explore the source changes: 0244593 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61b06e597ef02800089a8e83 |
@@ -1,11 +1,11 @@ | |||
--- | |||
api_metadata: | |||
apiVersion: "autoscaling/v2beta2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this change mean that the docs for HorizontalPodAutoscaler autoscaling/v2beta2
disappear? This might surprise readers given that lots of tools do use this API at autoscaling/v2beta2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this change will make it disappear. I will check if we can have both v2beta2 and v2 in documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sftim I've updated the doc to display v1, v2beta2 and v2 for HorizontalPodautoscaler:
https://deploy-preview-29668--kubernetes-io-vnext-staging.netlify.app/docs/reference/kubernetes-api/workload-resources/
The problem is that versions are not displayed in the titles for non beta versions, and thus it is difficult to distinguish between v1 and v2
What would we like to do?
- have only v2 and v2beta2?
- always display the versions in the title (this will display v1 for a lot of resources)
(2) will need to update the program building the documentation, where (1) only needs to modify the configuration in this repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we countenance a manual tweak, post build, for just the HPA APIs to show v1 and v2 explicitly, possibly followed by a logic tweak to show the version any time there are multiple stable APIs?
If we go for the logic tweak, SIG Docs can look for someone to pick up that work (ie: it doesn't have to be you @feloy - you already help a lot here!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should definitely aim to leave in docs for HPA v1; until the v1.23 release it's the API we officially recommend (v2beta2 is, of course, only beta). The day after that release folks would still expect to see docs for that v1 API available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you prefer @feloy ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we countenance a manual tweak, post build, for just the HPA APIs to show v1 and v2 explicitly, possibly followed by a logic tweak to show the version any time there are multiple stable APIs?
If we go for the logic tweak, SIG Docs can look for someone to pick up that work (ie: it doesn't have to be you @feloy - you already help a lot here!)
@sftim, Yes, it would be nice to have someone make some manual tweak after build with the necessary changes, so I can work on the logic one once I have a precise example of what to do.
f0c012b
to
ca646e0
Compare
although RC1 is the near complete version of 1.23, I'd still prefer deferring this to the formal release. |
OK, that's fair. We can post another build as soon as the release is available. |
LGTM label has been added. Git tree hash: 3cacc338c7690ed77bd4f125b93d781f7d6d37ea
|
Ok that works. I'll check back once we have a release tag for |
Hi @feloy 👋 1.23 is released and 1.23.0 tag is available. Can you rebuild/refresh this PR, and then rebase to main? Thanks! |
/remove-language zh |
/remove-area blog |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'd expect that https://deploy-preview-29668--kubernetes-io-main-staging.netlify.app/docs/reference/kubernetes-api/workload-resources/horizontal-pod-autoscaler-v2/ would work - and it doesn't. Even so, I've no objection to these changes going live, and then further fixups. |
Thanks @feloy . |
LGTM label has been added. Git tree hash: e86d0ff719db8f93b76e902e77f05c30fc057b49
|
Changes to the API reference for the upcoming v1.23