Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API reference v1.23 #29668

Merged
merged 1 commit into from
Dec 9, 2021
Merged

API reference v1.23 #29668

merged 1 commit into from
Dec 9, 2021

Conversation

feloy
Copy link
Member

@feloy feloy commented Sep 11, 2021

Changes to the API reference for the upcoming v1.23

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 11, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Sep 11, 2021
@feloy feloy changed the base branch from main to dev-1.23 September 11, 2021 09:55
@netlify
Copy link

netlify bot commented Sep 11, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: 294c5dc

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/613c7cfbb4d2c40008f2851d

😎 Browse the preview: https://deploy-preview-29668--kubernetes-io-main-staging.netlify.app

@sftim
Copy link
Contributor

sftim commented Sep 12, 2021

/milestone 1.23

@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Sep 12, 2021
@jimangel
Copy link
Member

@feloy thanks for getting a jump start on this! Is the plan to test it now and re-run it once SIG Release starts cutting release candidates (rc)?

@feloy
Copy link
Member Author

feloy commented Sep 13, 2021

@jimangel my idea is to update this PR as soon as new alpha/beta/RC are released, as is it easier to incorporate API changes by small chunks.

@reylejano
Copy link
Member

reylejano commented Sep 14, 2021

/cc @jlbutler @mehabhalodiya @chrisnegus @ramrodo @nate-double-u (1.23 Docs Release Team)

@jlbutler
Copy link
Contributor

/assign

@netlify
Copy link

netlify bot commented Nov 13, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 0244593

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/61b06e597ef02800089a8e83

@@ -1,11 +1,11 @@
---
api_metadata:
apiVersion: "autoscaling/v2beta2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this change mean that the docs for HorizontalPodAutoscaler autoscaling/v2beta2 disappear? This might surprise readers given that lots of tools do use this API at autoscaling/v2beta2.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change will make it disappear. I will check if we can have both v2beta2 and v2 in documentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim I've updated the doc to display v1, v2beta2 and v2 for HorizontalPodautoscaler:
https://deploy-preview-29668--kubernetes-io-vnext-staging.netlify.app/docs/reference/kubernetes-api/workload-resources/

The problem is that versions are not displayed in the titles for non beta versions, and thus it is difficult to distinguish between v1 and v2

What would we like to do?

  1. have only v2 and v2beta2?
  2. always display the versions in the title (this will display v1 for a lot of resources)

(2) will need to update the program building the documentation, where (1) only needs to modify the configuration in this repository.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we countenance a manual tweak, post build, for just the HPA APIs to show v1 and v2 explicitly, possibly followed by a logic tweak to show the version any time there are multiple stable APIs?

If we go for the logic tweak, SIG Docs can look for someone to pick up that work (ie: it doesn't have to be you @feloy - you already help a lot here!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely aim to leave in docs for HPA v1; until the v1.23 release it's the API we officially recommend (v2beta2 is, of course, only beta). The day after that release folks would still expect to see docs for that v1 API available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you prefer @feloy ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we countenance a manual tweak, post build, for just the HPA APIs to show v1 and v2 explicitly, possibly followed by a logic tweak to show the version any time there are multiple stable APIs?

If we go for the logic tweak, SIG Docs can look for someone to pick up that work (ie: it doesn't have to be you @feloy - you already help a lot here!)

@sftim, Yes, it would be nice to have someone make some manual tweak after build with the necessary changes, so I can work on the logic one once I have a precise example of what to do.

@jimangel
Copy link
Member

jimangel commented Dec 5, 2021

@feloy checking in, anything needed before Tuesday's release that we need to draw attention to?

/cc @jlbutler

@feloy feloy force-pushed the apiref-1.23 branch 2 times, most recently from f0c012b to ca646e0 Compare December 6, 2021 08:14
@feloy
Copy link
Member Author

feloy commented Dec 6, 2021

@feloy checking in, anything needed before Tuesday's release that we need to draw attention to?

/cc @jlbutler

No, this PR is up to date for v1.23 rc1.

@tengqm
Copy link
Contributor

tengqm commented Dec 7, 2021

although RC1 is the near complete version of 1.23, I'd still prefer deferring this to the formal release.

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 7, 2021

although RC1 is the near complete version of 1.23, I'd still prefer deferring this to the formal release.

OK, that's fair. We can post another build as soon as the release is available.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3cacc338c7690ed77bd4f125b93d781f7d6d37ea

@jlbutler
Copy link
Contributor

jlbutler commented Dec 7, 2021

Ok that works. I'll check back once we have a release tag for 1.23.0 and we can go from there. Thanks all!

@jlbutler
Copy link
Contributor

jlbutler commented Dec 7, 2021

The release tag v1.23.0 is published. Is someone available to refresh this PR with a release build?

@kbhawkey @feloy

@jlbutler jlbutler removed this from the 1.23 milestone Dec 8, 2021
@jlbutler
Copy link
Contributor

jlbutler commented Dec 8, 2021

Hi @feloy 👋

1.23 is released and 1.23.0 tag is available. Can you rebuild/refresh this PR, and then rebase to main? Thanks!

@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/zh Issues or PRs related to Chinese language and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 8, 2021
@feloy
Copy link
Member Author

feloy commented Dec 8, 2021

Hi @feloy wave

1.23 is released and 1.23.0 tag is available. Can you rebuild/refresh this PR, and then rebase to main? Thanks!

Hi @jlbutler I've updated to 1.23.0 tag, and rebased to main branch. Thanks

@feloy feloy changed the base branch from dev-1.23 to main December 8, 2021 08:38
@sftim
Copy link
Contributor

sftim commented Dec 8, 2021

/remove-language zh
/approve

@k8s-ci-robot k8s-ci-robot removed the language/zh Issues or PRs related to Chinese language label Dec 8, 2021
@sftim
Copy link
Contributor

sftim commented Dec 8, 2021

/remove-area blog

@k8s-ci-robot k8s-ci-robot removed the area/blog Issues or PRs related to the Kubernetes Blog subproject label Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021
@sftim
Copy link
Contributor

sftim commented Dec 8, 2021

I'd expect that https://deploy-preview-29668--kubernetes-io-main-staging.netlify.app/docs/reference/kubernetes-api/workload-resources/horizontal-pod-autoscaler-v2/ would work - and it doesn't.

Even so, I've no objection to these changes going live, and then further fixups.

@feloy
Copy link
Member Author

feloy commented Dec 8, 2021

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 9, 2021

@kbhawkey
Copy link
Contributor

kbhawkey commented Dec 9, 2021

Thanks @feloy .
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e86d0ff719db8f93b76e902e77f05c30fc057b49

@k8s-ci-robot k8s-ci-robot merged commit a50b7b9 into kubernetes:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants