Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): support Node16/NodeNext value for target #4429

Merged
merged 5 commits into from
Jul 10, 2024

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented Jul 8, 2024

Summary

Fixes #4198
Fixes #4156
Fixes #4245

Test plan

Green CI

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl force-pushed the fix/support-new-node-targets branch 5 times, most recently from 379ba59 to b943a84 Compare July 9, 2024 22:32
@ahnpnl ahnpnl force-pushed the fix/support-new-node-targets branch from b943a84 to e417ac8 Compare July 9, 2024 23:43
@ahnpnl ahnpnl force-pushed the fix/support-new-node-targets branch from e417ac8 to d44cbbf Compare July 9, 2024 23:47
@ahnpnl ahnpnl marked this pull request as ready for review July 9, 2024 23:53
@ahnpnl ahnpnl requested a review from kulshekhar as a code owner July 9, 2024 23:53
@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build 9866083387

Details

  • 31 of 31 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on fix/support-new-node-targets at 96.13%

Totals Coverage Status
Change from base Build 9862558237: 96.1%
Covered Lines: 4763
Relevant Lines: 4886

💛 - Coveralls

@ahnpnl ahnpnl merged commit ff4b302 into main Jul 10, 2024
17 checks passed
@ahnpnl ahnpnl deleted the fix/support-new-node-targets branch July 10, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants