chore: Remove RouterLink from globals, its replaced by XAction #2873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Cowen <john.cowen@konghq.com>
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: John Cowen <john.cowen@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces all remaining instances of
RouterLinkwithXAction, then removesRouterLinkfrom eslint globals.Note: RouterLink is still available for use, its just harder to use.
Replaces all remaining instances of
KButtonwithXAction.XActionusesKButtonunder-the-hoodWhy:
XActionis one single component for "let the user click this to perform an action". Engineers don't need to think about whether it should be a button, an anchor, a RouterLink, a KButton or something else and occasionally make the wrong choice. Just useXActionand all will be good.XActionalso comes with extra functionality to easily be able to update URL query strings with boolean?activeto meanactive=true.#2273
Lastly I've been waiting for a good time to do this (i.e. I don't have another bunch of potentially conflicting PRs up), and now felt like a good time to do it.