Add Gc::as_ref to get a &'gc T from a Gc<'gc, T>
#66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is sound, as `&'gc T` doesn't implement `Collect`, and so cannot escape the current arena callback.
moulins
changed the title
&'gc T from a Gc<'gc, T>Gc::as_ref to get a &'gc T from a Gc<'gc, T>
moulins
added a commit
to moulins/gc-arena
that referenced
this pull request
May 18, 2023
This is less error prone. Also, add some `'gc` lifetimes in `mutate(_root)` methods missed in kyren#66
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(also, add
impl AsRefforGc, and remove extra borrows from otherGc-taking methods)This is sound, as
&'gc Tdoesn't implementCollect(unless'gcends up being'static, which will be impossible once #63 is merged) and so cannot escape the current arena callback by being stored in the GC root.