廃止メソッド（getCount）および未使用プロパティ（ImageInfo#ZipIndex）削除 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated ZipArchiveInputStream#getCount method and unused ImageInfo#ZipIndex property.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated ZipArchiveInputStream#getCount method and unused ImageInfo#ZipIndex property.
廃止された ZipArchiveInputStream#getCount メソッドの警告を解消しました。
修正前のプログラムでは getCount の戻り値は最終的に ImageInfo のコンストラクタに渡され、ZipIndexプロパティに設定されます。
しかし、このプロパティは、ソースコードでもテンプレートでも使われていません。
リファクタリングも兼ね、getCountの呼び出しとZipIndexプロパティを削除しました。
(参考) 動作確認の手順
1. Epub3Writer.java の645行目
入力テキストファイル例
表紙: 10 行目までの [先頭の挿絵]
変換前確認: ON
（注意）変換前確認画面で縮尺を変えるなどして図形を編集する必要があります
2. ImageInfoReader.java の235行目
jpgやpngの画像を格納したフォルダを圧縮してドラッグ＆ドロップ