Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TLS client authentication at the host level #47

Merged
merged 5 commits into from
Mar 29, 2019

Conversation

alexandrestein
Copy link
Contributor

Because I use Armor as a gate way for some of my hosts I need to have different TLS configuration.

This pull request provides a way to set multiple client CA certificates encode into DER themselves encoded into base64 to verify client authentication.

I did not see any test files so I did not made any.

But I updated the documentation accordingly.

@vishr
Copy link
Member

vishr commented Feb 27, 2019

@alexandrestein I will back to it soon. Ping me if it is late.

@alexandrestein
Copy link
Contributor Author

Hi @vishr.
When do you think it's getting late? 😊

@alexandrestein
Copy link
Contributor Author

Hello @vishr.

It's really long now. 😞
The changes are pretty small and easy to review.

The massive changes at the documentation are accidental.
It has been made by my format engin.

Except the documentation, it is pretty clear what the code does.

Please consider tacking a look at this. 😉

@vishr vishr merged commit 336bc51 into labstack:master Mar 29, 2019
@alexandrestein
Copy link
Contributor Author

Great, thank you 🙏
💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants