Shouldn't middleware.Logger's default output to be the same as echo.Logger

[nattawitc]

Issue Description

The current behavior of middleware.Logger() is kind of counter-intuitive. When I set echo.Logger.SetOutput to be something else, I expect all log from echo should go to them. But right now if I use echo.Use(middleware.Logger()), the log will still write to os.Stdout.

I think the DefaultLoggerConfig.Output should be set to nil, and at the end of middleware.LoggerWithConfig, if config.Output == nil then use context.Logger.Output() instead

[alexaandru]

At the glance, this sounds reasonable to me, however it also sounds backward incompatible. If all of the sudden stdout logging is gone, that might break some setups. Esp., that it is the recommended way of logging for Docker, so people may actually rely on it quite a bit.

So I'm with you, I just don't see an easy way to handle this. Maybe keep it in mind for V4? Thoughts @vishr ?

[andradei]

V4 is here but just for compatibility with Go Modules. V5 then?

[vishr]

I think

I think the DefaultLoggerConfig.Output should be set to nil, and at the end of middleware.LoggerWithConfig, if config.Output == nil then use context.Logger.Output() instead

I am ok with this change, please send a PR.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[nattawitc]

After trying to fix this issue, I've stumbled upon some weird unit test.

In the function TestLoggerIPAddress that call assert.Contains(t, ip, bb), it checks whether bb (which is an empty string for all 3 cases) is contained in ip which is what we put in. Shouldn't it be the opposite, that we check for an ip if it is contained in the resulting logs bb. Is this intentional or a typo, because this test failed for my change.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.