Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing KeyFunc #1303

Closed
wants to merge 1 commit into from
Closed

Exposing KeyFunc #1303

wants to merge 1 commit into from

Conversation

zaker
Copy link

@zaker zaker commented Mar 8, 2019

When using auth servers that have more than one key that they sign the token with. It is useful to be able to validate the keys from outside the middle ware., e.g. provide a key fetch function.

Feel free to provide alternative solutions. Or if I should add some tests for this.

@codecov
Copy link

codecov bot commented Mar 8, 2019

Codecov Report

Merging #1303 into master will increase coverage by 1.84%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
+ Coverage   84.23%   86.08%   +1.84%     
==========================================
  Files          26       27       +1     
  Lines        1954     2263     +309     
==========================================
+ Hits         1646     1948     +302     
+ Misses        202      199       -3     
- Partials      106      116      +10
Impacted Files Coverage Δ
middleware/jwt.go 80% <77.77%> (+0.51%) ⬆️
middleware/util.go 84.37% <0%> (ø)
middleware/logger.go 86.61% <0%> (+1.42%) ⬆️
router.go 95.26% <0%> (+1.96%) ⬆️
group.go 96.05% <0%> (+2.3%) ⬆️
middleware/compress.go 73.91% <0%> (+2.48%) ⬆️
echo.go 91.28% <0%> (+3.08%) ⬆️
middleware/cors.go 81.53% <0%> (+6.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5434a53...5c05d50. Read the comment docs.

@DasJott
Copy link
Contributor

DasJott commented Mar 11, 2019

look here please

@stale
Copy link

stale bot commented May 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label May 10, 2019
@stale stale bot closed this May 17, 2019
@vishr vishr reopened this May 17, 2019
@stale stale bot removed the wontfix label May 17, 2019
@vishr
Copy link
Member

vishr commented May 17, 2019

@zaker #1289 is merged. Does that resolves your issue?

@zaker
Copy link
Author

zaker commented May 22, 2019

Yes, it probably will as soon as it hits release 👍

@zaker
Copy link
Author

zaker commented May 22, 2019

I'll close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants