reset p.values to echo.maxParam #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1429 +/- ##
=========================================
+ Coverage 84.09% 84.1% +0.01%
=========================================
Files 27 27
Lines 2068 2070 +2
=========================================
+ Hits 1739 1741 +2
Misses 214 214
Partials 115 115
Continue to review full report at Codecov.
|
How about just reset the values?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1428
This issue appears to have been related to sharing of param values between contexts in the pool. I added this fix to my local code base around 10 months ago and the issues experienced in the above issue have not been seen again in production.
The only time they appear again is if the change is accidentally reverted out, at which point we get 404s again.