Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suggestion] Add helper interface for ProxyBalancer interface #2316

Merged
merged 6 commits into from
Oct 29, 2022

Conversation

Hristov821
Copy link
Contributor

Idea is discussed in this issue

middleware/proxy.go Outdated Show resolved Hide resolved
middleware/proxy.go Outdated Show resolved Hide resolved
middleware/proxy_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add additional test for returning error and not proxing the request, as it was the reason for creating this PR.

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Base: 92.35% // Head: 92.37% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (2c28513) compared to base (8f2bf82).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2316      +/-   ##
==========================================
+ Coverage   92.35%   92.37%   +0.01%     
==========================================
  Files          37       37              
  Lines        4436     4446      +10     
==========================================
+ Hits         4097     4107      +10     
  Misses        247      247              
  Partials       92       92              
Impacted Files Coverage Δ
middleware/proxy.go 68.66% <100.00%> (+2.23%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Hristov821 Hristov821 requested a review from aldas October 27, 2022 18:49
middleware/proxy.go Outdated Show resolved Hide resolved
@Hristov821 Hristov821 requested a review from aldas October 29, 2022 16:07
Copy link
Contributor

@aldas aldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants