Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errno on DragonFly #19

Merged
merged 1 commit into from
May 2, 2018
Merged

Fix errno on DragonFly #19

merged 1 commit into from
May 2, 2018

Conversation

mneumann
Copy link
Contributor

__dfly_error has long been removed from the Rust souce.

__dfly_error has long been removed from the Rust souce.
Copy link
Owner

@lambda-fairy lambda-fairy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wary of adding another dependency, especially one that has C code.

Is there a way to query the errno directly? I would be happy with what is done in std.

@mneumann
Copy link
Contributor Author

@lfairy No, it's not possible at the moment with stable rust without a C extension, as thread_local is feature gated (rust-lang/rust#29594). The nix crate has imported my C code into their repository; they didn't like this crate as dependency, but I don't like to repeat that code in multiple crates. If you like you can copy that C code directly... but again, there is atm no other solution.

It works in stdlib only because stdlib is special-cased and allowed to use these features.

@lambda-fairy
Copy link
Owner

That's reasonable. I'll merge it as-is then.

Thanks!

@lambda-fairy lambda-fairy merged commit f56ecf2 into lambda-fairy:master May 2, 2018
@mneumann
Copy link
Contributor Author

mneumann commented May 2, 2018

@lfairy Thanks!

@mneumann mneumann deleted the fix-dragonfly branch May 7, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants