Share/Expose options and cleanup on exit #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have started to use the share command and I prefer to use a different server to default.
This PR allows people to set some of the main options in
.env
so they don't have to add them on the end of thesail share
command every time.I also noticed that the expose container does not get removed when you stop sharing - every time you run the command a new container will be created, to fix this issue I added
-rm
which will remove the container upon exitingExample:
Before
After