Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Expose 8080 port for hot module replacement" #432

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Jun 13, 2022

Reverts #391

As detailed at #391 (comment), Laravel Mix no longer works inside or outside the container without additional Mix configuration. If the user already needs to manually configure Mix, then they might as well just configure this part of their docker-compose.yml manually as well.

Please note that a similar feature for Vite is being added to Sail in #433, however it does not suffer the same issue because Laravel's first-party Vite plugin will automatically detect when it's inside Sail and will listen on the appropriate host. Additionally, Vite will automatically find an available port when the default is in use, and the Laravel plugin will add the correct port to the public/hot file, allowing Vite to be used both in and outside the container with no additional configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants