feat: Account name completion using matchfuzzy #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is currently missing documentation which I can add once I get some reviews and it looks like a good addition to the plugin. |
alerque
requested changes
May 2, 2024
This commit adds an alternative way for completing account names
to the pre-existing completion function. Here's an example:
```
commodity 1,000.00 USD
account Assets:Bank:Bofa:Checking
account Assets:Bank:Bofa:Savings
account Assets:Bank:Chase:Checking
account Assets:Bank:Chase:Savings
account Expenses:Coffee
2024-01-10 Buy Coffee
Expenses:Coffee 5.00 USD
bofa█
,___________________________,
| Assets:Bank:Bofa:Savings |
| Assets:Bank:Bofa:Checking |
'---------------------------'
```
The older completion mechanism would need several keypresses before
it can insert the Bofa:Checking account especially in a big ledger
with a lot of accounts. I have found this fuzzy approach to be faster
in my workflow and expect that other people might find it helpful too.
lakshayg
force-pushed
the
fuzzy_acct_completion
branch
from
ca89864
to
36b7ccb
Compare
|
@alerque I have updated the docs. Please re-review |
alerque
requested changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds an alternative way for completing account names to the pre-existing completion function. Here's an example:
The older completion mechanism would need several keypresses before it can insert the Bofa:Checking account especially in a big ledger with a lot of accounts. I have found this fuzzy approach to be faster in my workflow and expect that other people might find it helpful too.