Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review "advanced alignment mode" commits for workable contributions #95

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

alerque
Copy link
Member

@alerque alerque commented Nov 4, 2019

This set of commits from @dedmons has some interesting ideas, adding here as a PR to consider for possible inclusion and/or reworking.

In advance alignment mode, it behaves similar to emacs
alignment.

Activated by setting g:ledger_align_advance = 1
@dedmons
Copy link

dedmons commented Dec 1, 2019

Hey @alerque. Sorry for the super long delay in replying.

I am more than happy for this to get merged in and fixed up for other commodities.

Do you need me to open a PR or can this get converted into one?

@alerque
Copy link
Member Author

alerque commented Dec 1, 2019

Hey no worries on the timing. This PR is against your master branch so anything you do there will show up here. This would probably require rebasing your master branch to be productive. If you'd rather work on a new branch taken from the current master and cherry pick or merge into that you can submit that as a separate PR. Either way let me know if there is anything I can do to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants